Commit 8e28276a authored by Kees Cook's avatar Kees Cook
Browse files

watchdog: exar: Shorten identity name to fit correctly 



The static initializer for struct watchdog_info::identity is too long
and gets initialized without a trailing NUL byte. Since the length
of "identity" is part of UAPI and tied to ioctls, just shorten
the name of the device. Avoids the warning seen with GCC 15's
-Wunterminated-string-initialization option:

drivers/watchdog/exar_wdt.c:224:27: warning: initializer-string for array of 'unsigned char' truncates NUL terminator but destination lacks 'nonstring' attribute (33 chars into 32 available) [-Wunterminated-string-initialization]
  224 |         .identity       = "Exar/MaxLinear XR28V38x Watchdog",
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 81126222 ("watchdog: Exar/MaxLinear XR28V38x driver")
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20250415225246.work.458-kees@kernel.org


Signed-off-by: default avatarKees Cook <kees@kernel.org>
parent 65586286

drivers/watchdog/exar_wdt.c

+1 −1
Original line number Diff line number Diff line
@@ -221,7 +221,7 @@ static const struct watchdog_info exar_wdt_info = { 
	.options	= WDIOF_KEEPALIVEPING |

			  WDIOF_SETTIMEOUT |

			  WDIOF_MAGICCLOSE,

	.identity	= "Exar/MaxLinear XR28V38x Watchdog",

	.identity	= "Exar XR28V38x Watchdog",

};



static const struct watchdog_ops exar_wdt_ops = {