Commit 8e4c0f08 authored by Daniel Golle's avatar Daniel Golle Committed by Paolo Abeni
Browse files

net: dsa: mxl-gsw1xx: fix order in .remove operation 



The driver's .remove operation was calling gswip_disable_switch() which
clears the GSWIP_MDIO_GLOB_ENABLE bit before calling
dsa_unregister_switch() and thereby violating a Golden Rule of driver
development to always unpublish userspace interfaces before disabling
hardware, as pointed out by Russell King.

Fix this by relying in GSWIP_MDIO_GLOB_ENABLE being cleared by the
.teardown operation introduced by the previous commit
("net: dsa: lantiq_gswip: fix teardown order").

Fixes: 22335939 ("net: dsa: add driver for MaxLinear GSW1xx switch family")
Suggested-by: default avatar"Russell King (Oracle)" <linux@armlinux.org.uk>
Signed-off-by: default avatarDaniel Golle <daniel@makrotopia.org>
Link: https://patch.msgid.link/63f882eeb910cf24503c35a443b541cc54a930f2.1765241054.git.daniel@makrotopia.org


Reviewed-by: default avatarVladimir Oltean <olteanv@gmail.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 377d66fa

drivers/net/dsa/lantiq/mxl-gsw1xx.c

+0 −2
Original line number Diff line number Diff line
@@ -652,8 +652,6 @@ static void gsw1xx_remove(struct mdio_device *mdiodev) 
	if (!priv)

		return;



	gswip_disable_switch(priv);



	dsa_unregister_switch(priv->ds);

}