Commit 8f067aa5 authored by Yuhao Jiang's avatar Yuhao Jiang Committed by Rafael J. Wysocki
Browse files

ACPI: video: Fix use-after-free in acpi_video_switch_brightness() 



The switch_brightness_work delayed work accesses device->brightness
and device->backlight, freed by acpi_video_dev_unregister_backlight()
during device removal.

If the work executes after acpi_video_bus_unregister_backlight()
frees these resources, it causes a use-after-free when
acpi_video_switch_brightness() dereferences device->brightness or
device->backlight.

Fix this by calling cancel_delayed_work_sync() for each device's
switch_brightness_work in acpi_video_bus_remove_notify_handler()
after removing the notify handler that queues the work. This ensures
the work completes before the memory is freed.

Fixes: 8ab58e8e ("ACPI / video: Fix backlight taking 2 steps on a brightness up/down keypress")
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: default avatarYuhao Jiang <danisjiang@gmail.com>
Reviewed-by: default avatarHans de Goede <hansg@kernel.org>
[ rjw: Changelog edit ]
Link: https://patch.msgid.link/20251022200704.2655507-1-danisjiang@gmail.com


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 211ddde0

drivers/acpi/acpi_video.c

+3 −1
Original line number Diff line number Diff line
@@ -1959,8 +1959,10 @@ static void acpi_video_bus_remove_notify_handler(struct acpi_video_bus *video) 
	struct acpi_video_device *dev;



	mutex_lock(&video->device_list_lock);

	list_for_each_entry(dev, &video->video_device_list, entry)

	list_for_each_entry(dev, &video->video_device_list, entry) {

		acpi_video_dev_remove_notify_handler(dev);

		cancel_delayed_work_sync(&dev->switch_brightness_work);

	}

	mutex_unlock(&video->device_list_lock);



	acpi_video_bus_stop_devices(video);