Commit 8ff61751 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Jakub Kicinski
Browse files

bnxt_en: hide CONFIG_DETECT_HUNG_TASK specific code 



The CONFIG_DEFAULT_HUNG_TASK_TIMEOUT setting is only available when the
hung task detection is enabled, otherwise the code now produces a build
failure:

drivers/net/ethernet/broadcom/bnxt/bnxt.c:10188:21: error: use of undeclared identifier 'CONFIG_DEFAULT_HUNG_TASK_TIMEOUT'
 10188 |             max_tmo_secs > CONFIG_DEFAULT_HUNG_TASK_TIMEOUT) {

Enclose this warning logic in an #ifdef to ensure this builds.

Fixes: 0fcad44a ("bnxt_en: Change FW message timeout warning")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarMichael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20250423162827.2189658-1-arnd@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 88922fe7

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+2 −0
Original line number Diff line number Diff line
@@ -10184,11 +10184,13 @@ static int bnxt_hwrm_ver_get(struct bnxt *bp) 
	if (!bp->hwrm_cmd_max_timeout)

		bp->hwrm_cmd_max_timeout = HWRM_CMD_MAX_TIMEOUT;

	max_tmo_secs = bp->hwrm_cmd_max_timeout / 1000;

#ifdef CONFIG_DETECT_HUNG_TASK

	if (bp->hwrm_cmd_max_timeout > HWRM_CMD_MAX_TIMEOUT ||

	    max_tmo_secs > CONFIG_DEFAULT_HUNG_TASK_TIMEOUT) {

		netdev_warn(bp->dev, "Device requests max timeout of %d seconds, may trigger hung task watchdog (kernel default %ds)\n",

			    max_tmo_secs, CONFIG_DEFAULT_HUNG_TASK_TIMEOUT);

	}

#endif



	if (resp->hwrm_intf_maj_8b >= 1) {

		bp->hwrm_max_req_len = le16_to_cpu(resp->max_req_win_len);