Commit 90022b3a authored by Shuai Xue's avatar Shuai Xue Committed by Vinod Koul
Browse files

dmaengine: idxd: fix memory leak in error handling path of idxd_pci_probe 



Memory allocated for idxd is not freed if an error occurs during
idxd_pci_probe(). To fix it, free the allocated memory in the reverse
order of allocation before exiting the function in case of an error.

Fixes: bfe1d560 ("dmaengine: idxd: Init and probe for Intel data accelerators")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarShuai Xue <xueshuai@linux.alibaba.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatarFenghua Yu <fenghuay@nvidia.com>
Link: https://lore.kernel.org/r/20250404120217.48772-8-xueshuai@linux.alibaba.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 46a5cca7

drivers/dma/idxd/init.c

+12 −1
Original line number Diff line number Diff line
@@ -587,6 +587,17 @@ static void idxd_read_caps(struct idxd_device *idxd) 
		idxd->hw.iaa_cap.bits = ioread64(idxd->reg_base + IDXD_IAACAP_OFFSET);

}



static void idxd_free(struct idxd_device *idxd)

{

	if (!idxd)

		return;



	put_device(idxd_confdev(idxd));

	bitmap_free(idxd->opcap_bmap);

	ida_free(&idxd_ida, idxd->id);

	kfree(idxd);

}



static struct idxd_device *idxd_alloc(struct pci_dev *pdev, struct idxd_driver_data *data)

{

	struct device *dev = &pdev->dev;
@@ -1255,7 +1266,7 @@ int idxd_pci_probe_alloc(struct idxd_device *idxd, struct pci_dev *pdev, 
 err:

	pci_iounmap(pdev, idxd->reg_base);

 err_iomap:

	put_device(idxd_confdev(idxd));

	idxd_free(idxd);

 err_idxd_alloc:

	pci_disable_device(pdev);

	return rc;