Commit 904f4f64 authored by Parav Pandit's avatar Parav Pandit Committed by Jason Gunthorpe
Browse files

IB/core: Use valid port number to check link layer 

IB HCA port starts from 1. Use IB core provided port iterator API to avoid
any assumption with start port number.

Link: https://lore.kernel.org/r/20210127150010.1876121-11-leon@kernel.org


Signed-off-by: default avatarParav Pandit <parav@nvidia.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 6504c772

drivers/infiniband/core/verbs.c

+2 −2
Original line number Diff line number Diff line
@@ -2248,7 +2248,7 @@ static bool is_valid_mcast_lid(struct ib_qp *qp, u16 lid) 
	struct ib_qp_init_attr init_attr = {};

	struct ib_qp_attr attr = {};

	int num_eth_ports = 0;

	int port;

	unsigned int port;



	/* If QP state >= init, it is assigned to a port and we can check this

	 * port only.
@@ -2263,7 +2263,7 @@ static bool is_valid_mcast_lid(struct ib_qp *qp, u16 lid) 
	}



	/* Can't get a quick answer, iterate over all ports */

	for (port = 0; port < qp->device->phys_port_cnt; port++)

	rdma_for_each_port(qp->device, port)

		if (rdma_port_get_link_layer(qp->device, port) !=

		    IB_LINK_LAYER_INFINIBAND)

			num_eth_ports++;