Commit 90f1015d authored by Zqiang's avatar Zqiang Committed by Neeraj Upadhyay (AMD)
Browse files

rcutorture: Add fqs_holdoff check before fqs_task is created 



For rcutorture tests on RCU implementations that support
force-quiescent-state operations and that set the fqs_duration module
parameter greater than zero, the fqs_task kthread will be created.
However, if the fqs_holdoff module parameter is not set, then its default
value of zero will cause fqs_task enter a long-term busy loop until
stopped by kthread_stop().  This commit therefore adds a fqs_holdoff
check before the fqs_task is created, making sure that whenever the
fqs_task is created, the fqs_holdoff will be greater than zero.

Signed-off-by: default avatarZqiang <qiang.zhang1211@gmail.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
Signed-off-by: default avatarNeeraj Upadhyay (AMD) <neeraj.iitr10@gmail.com>
parent af19a252

kernel/rcu/rcutorture.c

+3 −1
Original line number Diff line number Diff line
@@ -3872,7 +3872,9 @@ rcu_torture_init(void) 
	}

	if (fqs_duration < 0)

		fqs_duration = 0;

	if (fqs_duration) {

	if (fqs_holdoff < 0)

		fqs_holdoff = 0;

	if (fqs_duration && fqs_holdoff) {

		/* Create the fqs thread */

		firsterr = torture_create_kthread(rcu_torture_fqs, NULL,

						  fqs_task);