Commit 914b2fd2 authored by Rob Herring's avatar Rob Herring Committed by Guenter Roeck
Browse files

hwmon: (ibmpowernv, pwm-fan) Use of_property_present() for testing DT property presence 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230310144706.1542434-1-robh@kernel.org


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 50c3480b

drivers/hwmon/ibmpowernv.c

+2 −2
Original line number Diff line number Diff line
@@ -456,9 +456,9 @@ static int populate_attr_groups(struct platform_device *pdev) 
		 */

		if (!of_property_read_string(np, "label", &label))

			sensor_groups[type].attr_count++;

		if (of_find_property(np, "sensor-data-min", NULL))

		if (of_property_present(np, "sensor-data-min"))

			sensor_groups[type].attr_count++;

		if (of_find_property(np, "sensor-data-max", NULL))

		if (of_property_present(np, "sensor-data-max"))

			sensor_groups[type].attr_count++;

	}

drivers/hwmon/pwm-fan.c

+1 −1
Original line number Diff line number Diff line
@@ -427,7 +427,7 @@ static int pwm_fan_of_get_cooling_data(struct device *dev, 
	struct device_node *np = dev->of_node;

	int num, i, ret;



	if (!of_find_property(np, "cooling-levels", NULL))

	if (!of_property_present(np, "cooling-levels"))

		return 0;



	ret = of_property_count_u32_elems(np, "cooling-levels");