Commit 9160fb7c authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Vinod Koul
Browse files

dt-bindings: phy: qcom,usb-snps-femto-v2: use fallback compatibles 



Document SoC-specific compatibles with generic fallback (e.g.
qcom,usb-snps-hs-7nm-phy) already used in DTSI.  Add SoC-specific
compatibles for PHY on SDX55 and SDX65.

This disallows usage of the qcom,usb-snps-hs-5nm-phy and
qcom,usb-snps-hs-7nm-phy generic compatibles alone.  Do not touch
remaining two compatibles - qcom,usb-snps-femto-v2-phy and
qcom,sc8180x-usb-hs-phy - because there are no upstream users, so not
sure what was the intention for them.

This fixes warnings like:

  sa8295p-adp.dtb: phy@88e5000: compatible: 'oneOf' conditional failed, one must be fixed:
    ['qcom,sc8280xp-usb-hs-phy', 'qcom,usb-snps-hs-5nm-phy'] is too long
    'qcom,sc8280xp-usb-hs-phy' is not one of ['qcom,sm8150-usb-hs-phy', 'qcom,sm8250-usb-hs-phy', 'qcom,sm8350-usb-hs-phy', 'qcom,sm8450-usb-hs-phy']
    'qcom,usb-snps-hs-7nm-phy' was expected

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20221223161835.112079-1-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 50133cd3

Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml

+20 −13
Original line number Diff line number Diff line
@@ -14,18 +14,25 @@ description: | 


properties:

  compatible:

    enum:

      - qcom,usb-snps-hs-5nm-phy

      - qcom,usb-snps-hs-7nm-phy

      - qcom,sc7280-usb-hs-phy

    oneOf:

      - enum:

          - qcom,sc8180x-usb-hs-phy

          - qcom,usb-snps-femto-v2-phy

      - items:

          - enum:

              - qcom,sc8280xp-usb-hs-phy

          - const: qcom,usb-snps-hs-5nm-phy

      - items:

          - enum:

              - qcom,sc7280-usb-hs-phy

              - qcom,sdx55-usb-hs-phy

              - qcom,sdx65-usb-hs-phy

              - qcom,sm6375-usb-hs-phy

              - qcom,sm8150-usb-hs-phy

              - qcom,sm8250-usb-hs-phy

              - qcom,sm8350-usb-hs-phy

              - qcom,sm8450-usb-hs-phy

      - qcom,usb-snps-femto-v2-phy

          - const: qcom,usb-snps-hs-7nm-phy



  reg:

    maxItems: 1
@@ -160,7 +167,7 @@ examples: 
    #include <dt-bindings/clock/qcom,rpmh.h>

    #include <dt-bindings/clock/qcom,gcc-sm8150.h>

    phy@88e2000 {

        compatible = "qcom,sm8150-usb-hs-phy";

        compatible = "qcom,sm8150-usb-hs-phy", "qcom,usb-snps-hs-7nm-phy";

        reg = <0x088e2000 0x400>;

        #phy-cells = <0>;