Commit 922ec313 authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf annotate-data: Fix missing constant copy 



I found it missed to copy the immediate constant when it moves the
register value.  This could result in a wrong type inference since the
address for the per-cpu variable would be 0 always.

Fixes: eb9190af ("perf annotate-data: Handle ADD instructions")
Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20240821065408.285548-1-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent e25ebda7

tools/perf/arch/x86/annotate/instructions.c

+1 −0
Original line number Diff line number Diff line
@@ -382,6 +382,7 @@ static void update_insn_state_x86(struct type_state *state, 


		tsr->type = state->regs[src->reg1].type;

		tsr->kind = state->regs[src->reg1].kind;

		tsr->imm_value = state->regs[src->reg1].imm_value;

		tsr->ok = true;



		pr_debug_dtp("mov [%x] reg%d -> reg%d",