Commit 92c749e4 authored by Wei-Lin Chang's avatar Wei-Lin Chang Committed by Marc Zyngier
Browse files

KVM: arm64: nv: Remove clearing of ICH_LR<n>.EOI if ICH_LR<n>.HW == 1 



In the case of ICH_LR<n>.HW == 1, bit 41 of LR is just a part of pINTID
without EOI meaning, and bit 41 will be zeroed by the subsequent clearing
of ICH_LR_PHYS_ID_MASK anyway.
No functional changes intended.

Signed-off-by: default avatarWei-Lin Chang <r09922117@csie.ntu.edu.tw>
Link: https://lore.kernel.org/r/20250512133223.866999-1-r09922117@csie.ntu.edu.tw


Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
parent 00b0300c

arch/arm64/kvm/vgic/vgic-v3-nested.c

+0 −3
Original line number Diff line number Diff line
@@ -240,9 +240,6 @@ static void vgic_v3_create_shadow_lr(struct kvm_vcpu *vcpu, 
			goto next;

		}



		/* It is illegal to have the EOI bit set with HW */

		lr &= ~ICH_LR_EOI;



		/* Translate the virtual mapping to the real one */

		lr &= ~ICH_LR_PHYS_ID_MASK;

		lr |= FIELD_PREP(ICH_LR_PHYS_ID_MASK, (u64)irq->hwintid);