Commit 92eb132a authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: dwc: ep: Call epc_create() early in dw_pcie_ep_init() 

Move devm_pci_epc_create() to the beginning of dw_pcie_ep_init().

devm_pci_epc_create() is generic code that doesn't depend on any DWC
resource, so moving it earlier keeps all the subsequent devicetree-related
code together.

Link: https://lore.kernel.org/r/20250315201548.858189-9-helgaas@kernel.org


Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
parent 7db02f72

drivers/pci/controller/dwc/pcie-designware-ep.c

+9 −9
Original line number Diff line number Diff line
@@ -904,6 +904,15 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) 


	INIT_LIST_HEAD(&ep->func_list);



	epc = devm_pci_epc_create(dev, &epc_ops);

	if (IS_ERR(epc)) {

		dev_err(dev, "Failed to create epc device\n");

		return PTR_ERR(epc);

	}



	ep->epc = epc;

	epc_set_drvdata(epc, ep);



	ret = dw_pcie_get_resources(pci);

	if (ret)

		return ret;
@@ -918,15 +927,6 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) 
	if (ep->ops->pre_init)

		ep->ops->pre_init(ep);



	epc = devm_pci_epc_create(dev, &epc_ops);

	if (IS_ERR(epc)) {

		dev_err(dev, "Failed to create epc device\n");

		return PTR_ERR(epc);

	}



	ep->epc = epc;

	epc_set_drvdata(epc, ep);



	ret = of_property_read_u8(np, "max-functions", &epc->max_functions);

	if (ret < 0)

		epc->max_functions = 1;