Commit 935e1d90 authored by Danilo Krummrich's avatar Danilo Krummrich Committed by Greg Kroah-Hartman
Browse files

rust: pci: require Send for Driver trait implementers 



The instance of Self, returned and created by Driver::probe() is
dropped in the bus' remove() callback.

Request implementers of the Driver trait to implement Send, since the
remove() callback is not guaranteed to run from the same thread as
probe().

Fixes: 1bd8b6b2 ("rust: pci: add basic PCI device / driver abstractions")
Cc: stable <stable@kernel.org>
Reported-by: default avatarAlice Ryhl <aliceryhl@google.com>
Closes: https://lore.kernel.org/lkml/Z9rDxOJ2V2bPjj5i@google.com/


Signed-off-by: default avatarDanilo Krummrich <dakr@kernel.org>
Reviewed-by: default avatarBenno Lossin <benno.lossin@proton.me>
Link: https://lore.kernel.org/r/20250319145350.69543-1-dakr@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 455943aa

rust/kernel/pci.rs

+1 −1
Original line number Diff line number Diff line
@@ -222,7 +222,7 @@ macro_rules! pci_device_table { 
///```

/// Drivers must implement this trait in order to get a PCI driver registered. Please refer to the

/// `Adapter` documentation for an example.

pub trait Driver {

pub trait Driver: Send {

    /// The type holding information about each device id supported by the driver.

    ///

    /// TODO: Use associated_type_defaults once stabilized: