Commit 937a1c29 authored by Viktor Malik's avatar Viktor Malik Committed by Andrii Nakryiko
Browse files

selftests/bpf: skip the timer_lockup test for single-CPU nodes 



The timer_lockup test needs 2 CPUs to work, on single-CPU nodes it fails
to set thread affinity to CPU 1 since it doesn't exist:

    # ./test_progs -t timer_lockup
    test_timer_lockup:PASS:timer_lockup__open_and_load 0 nsec
    test_timer_lockup:PASS:pthread_create thread1 0 nsec
    test_timer_lockup:PASS:pthread_create thread2 0 nsec
    timer_lockup_thread:PASS:cpu affinity 0 nsec
    timer_lockup_thread:FAIL:cpu affinity unexpected error: 22 (errno 0)
    test_timer_lockup:PASS: 0 nsec
    #406     timer_lockup:FAIL

Skip the test if only 1 CPU is available.

Signed-off-by: default avatarViktor Malik <vmalik@redhat.com>
Fixes: 50bd5a0c ("selftests/bpf: Add timer lockup selftest")
Tested-by: default avatarPhilo Lu <lulie@linux.alibaba.com>
Acked-by: default avatarKumar Kartikeya Dwivedi <memxor@gmail.com>
Link: https://lore.kernel.org/r/20241107115231.75200-1-vmalik@redhat.com


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
parent 266a5579

tools/testing/selftests/bpf/prog_tests/timer_lockup.c

+6 −0
Original line number Diff line number Diff line
@@ -5,6 +5,7 @@ 
#include <test_progs.h>

#include <pthread.h>

#include <network_helpers.h>

#include <sys/sysinfo.h>



#include "timer_lockup.skel.h"
@@ -52,6 +53,11 @@ void test_timer_lockup(void) 
	pthread_t thrds[2];

	void *ret;



	if (get_nprocs() < 2) {

		test__skip();

		return;

	}



	skel = timer_lockup__open_and_load();

	if (!ASSERT_OK_PTR(skel, "timer_lockup__open_and_load"))

		return;