Commit 9391380e authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

slimbus: core: fix device reference leak on report present 



Slimbus devices can be allocated dynamically upon reception of
report-present messages.

Make sure to drop the reference taken when looking up already registered
devices.

Note that this requires taking an extra reference in case the device has
not yet been registered and has to be allocated.

Fixes: 46a2bb5a ("slimbus: core: Add slim controllers support")
Cc: stable@vger.kernel.org	# 4.16
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20251126145329.5022-4-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0eb4ff65

drivers/slimbus/core.c

+3 −0
Original line number Diff line number Diff line
@@ -379,6 +379,8 @@ struct slim_device *slim_get_device(struct slim_controller *ctrl, 
		sbdev = slim_alloc_device(ctrl, e_addr, NULL);

		if (!sbdev)

			return ERR_PTR(-ENOMEM);



		get_device(&sbdev->dev);

	}



	return sbdev;
@@ -505,6 +507,7 @@ int slim_device_report_present(struct slim_controller *ctrl, 
		ret = slim_device_alloc_laddr(sbdev, true);

	}



	put_device(&sbdev->dev);

out_put_rpm:

	pm_runtime_mark_last_busy(ctrl->dev);

	pm_runtime_put_autosuspend(ctrl->dev);