Commit 9536a091 authored by Johannes Berg's avatar Johannes Berg
Browse files

wifi: iwlwifi: pcie: enable TOP fatal error interrupt 



Enable the TOP (HW part) fatal error interrupt and add a
print when it happens. Currently FW always adds also the
SW error interrupt, but for >= Bz we'll need to do PLDR
in case this is asserted, so leave a TODO item already.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230913145231.127d914a4d0d.I41ea409df63474554ef727c49382d0b5bf15939e@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent af9d34ab

drivers/net/wireless/intel/iwlwifi/iwl-csr.h

+1 −0
Original line number Diff line number Diff line
@@ -618,6 +618,7 @@ enum msix_hw_int_causes { 
	MSIX_HW_INT_CAUSES_REG_WAKEUP		= BIT(1),

	MSIX_HW_INT_CAUSES_REG_IML              = BIT(1),

	MSIX_HW_INT_CAUSES_REG_RESET_DONE	= BIT(2),

	MSIX_HW_INT_CAUSES_REG_TOP_FATAL_ERR	= BIT(3),

	MSIX_HW_INT_CAUSES_REG_SW_ERR_BZ	= BIT(5),

	MSIX_HW_INT_CAUSES_REG_CT_KILL		= BIT(6),

	MSIX_HW_INT_CAUSES_REG_RF_KILL		= BIT(7),

drivers/net/wireless/intel/iwlwifi/pcie/rx.c

+6 −0
Original line number Diff line number Diff line
@@ -2291,6 +2291,12 @@ irqreturn_t iwl_pcie_irq_msix_handler(int irq, void *dev_id) 
	else

		sw_err = inta_hw & MSIX_HW_INT_CAUSES_REG_SW_ERR;



	if (inta_hw & MSIX_HW_INT_CAUSES_REG_TOP_FATAL_ERR) {

		IWL_ERR(trans, "TOP Fatal error detected, inta_hw=0x%x.\n",

			inta_hw);

		/* TODO: PLDR flow required here for >= Bz */

	}



	/* Error detected by uCode */

	if ((inta_fh & MSIX_FH_INT_CAUSES_FH_ERR) || sw_err) {

		IWL_ERR(trans,

drivers/net/wireless/intel/iwlwifi/pcie/trans.c

+1 −0
Original line number Diff line number Diff line
@@ -1111,6 +1111,7 @@ static const struct iwl_causes_list causes_list_common[] = { 
	IWL_CAUSE(CSR_MSIX_HW_INT_MASK_AD, MSIX_HW_INT_CAUSES_REG_ALIVE),

	IWL_CAUSE(CSR_MSIX_HW_INT_MASK_AD, MSIX_HW_INT_CAUSES_REG_WAKEUP),

	IWL_CAUSE(CSR_MSIX_HW_INT_MASK_AD, MSIX_HW_INT_CAUSES_REG_RESET_DONE),

	IWL_CAUSE(CSR_MSIX_HW_INT_MASK_AD, MSIX_HW_INT_CAUSES_REG_TOP_FATAL_ERR),

	IWL_CAUSE(CSR_MSIX_HW_INT_MASK_AD, MSIX_HW_INT_CAUSES_REG_CT_KILL),

	IWL_CAUSE(CSR_MSIX_HW_INT_MASK_AD, MSIX_HW_INT_CAUSES_REG_RF_KILL),

	IWL_CAUSE(CSR_MSIX_HW_INT_MASK_AD, MSIX_HW_INT_CAUSES_REG_PERIODIC),