Commit 956b610c authored Oct 06, 2023 by Cezary Rojewski Committed by Takashi Iwai Oct 06, 2023

ALSA: hda: Fix stream fifo_size initialization



SDxFIFOS register indicates the fifo size directly. There is no need to
modify the value after reading the register.

Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20231006102857.749143-3-cezary.rojewski@intel.com


Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent f93dc90c

sound/hda/hdac_stream.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -308,7 +308,7 @@ int snd_hdac_stream_setup(struct hdac_stream *azx_dev)
		if (ret)
		dev_dbg(bus->dev, "polling SD_FIFOSIZE 0x%04x failed: %d\n",
		AZX_REG_SD_FIFOSIZE, ret);
		azx_dev->fifo_size = snd_hdac_stream_readw(azx_dev, SD_FIFOSIZE) + 1;
		azx_dev->fifo_size = snd_hdac_stream_readw(azx_dev, SD_FIFOSIZE);

		/* when LPIB delay correction gives a small negative value,
		* we ignore it; currently set the threshold statically to

sound/pci/hda/hda_intel.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -806,7 +806,7 @@ static unsigned int azx_via_get_position(struct azx *chip,
		mod_dma_pos = le32_to_cpu(*azx_dev->core.posbuf);
		mod_dma_pos %= azx_dev->core.period_bytes;

		fifo_size = azx_stream(azx_dev)->fifo_size - 1;
		fifo_size = azx_stream(azx_dev)->fifo_size;

		if (azx_dev->insufficient) {
		/* Link position never gather than FIFO size */