Unverified Commit 95f723cf authored by Henry Martin's avatar Henry Martin Committed by Mark Brown
Browse files

ASoC: Intel: avs: Fix null-ptr-deref in avs_component_probe() 



devm_kasprintf() returns NULL when memory allocation fails. Currently,
avs_component_probe() does not check for this case, which results in a
NULL pointer dereference.

Fixes: 739c0311 ("ASoC: Intel: avs: Provide support for fallback topology")
Reviewed-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Reviewed-by: default avatarEthan Carter Edwards <ethan@ethancedwards.com>
Signed-off-by: default avatarHenry Martin <bsdhenrymartin@gmail.com>
Link: https://patch.msgid.link/20250402141411.44972-1-bsdhenrymartin@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ef5c23ae

sound/soc/intel/avs/pcm.c

+2 −1
Original line number Diff line number Diff line
@@ -927,7 +927,8 @@ static int avs_component_probe(struct snd_soc_component *component) 
		else

			mach->tplg_filename = devm_kasprintf(adev->dev, GFP_KERNEL,

							     "hda-generic-tplg.bin");



		if (!mach->tplg_filename)

			return -ENOMEM;

		filename = kasprintf(GFP_KERNEL, "%s/%s", component->driver->topology_name_prefix,

				     mach->tplg_filename);

		if (!filename)