Commit 961ac9d9 authored by Harshita Bhilwaria's avatar Harshita Bhilwaria Committed by Herbert Xu
Browse files

crypto: qat - fix duplicate restarting msg during AER error 



The restarting message from PF to VF is sent twice during AER error
handling: once from adf_error_detected() and again from
adf_disable_sriov().
This causes userspace subservices to shutdown unexpectedly when they
receive a duplicate restarting message after already being restarted.

Avoid calling adf_pf2vf_notify_restarting() and
adf_pf2vf_wait_for_restarting_complete() from adf_error_detected() so
that the restarting msg is sent only once from PF to VF.

Fixes: 9567d3dc ("crypto: qat - improve aer error reset handling")
Signed-off-by: default avatarHarshita Bhilwaria <harshita.bhilwaria@intel.com>
Reviewed-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: default avatarAhsan Atta <ahsan.atta@intel.com>
Reviewed-by: default avatarRavikumar PM <ravikumar.pm@intel.com>
Reviewed-by: default avatarSrikanth Thokala <srikanth.thokala@intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent b74fd80d

drivers/crypto/intel/qat/qat_common/adf_aer.c

+0 −2
Original line number Diff line number Diff line
@@ -41,8 +41,6 @@ static pci_ers_result_t adf_error_detected(struct pci_dev *pdev, 
	adf_error_notifier(accel_dev);

	adf_pf2vf_notify_fatal_error(accel_dev);

	adf_dev_restarting_notify(accel_dev);

	adf_pf2vf_notify_restarting(accel_dev);

	adf_pf2vf_wait_for_restarting_complete(accel_dev);

	pci_clear_master(pdev);

	adf_dev_down(accel_dev);