Commit 973f47a9 authored by Leo Yan's avatar Leo Yan Committed by Suzuki K Poulose
Browse files

coresight: perf: Update buffer on AUX pause 



Due to sinks like ETR and ETB don't support interrupt handling, the
hardware trace data might be lost for continuous running tasks.

This commit takes advantage of the AUX pause for updating trace buffer
to mitigate the trace data losing issue.

The per CPU sink has its own interrupt handling.  Thus, there will be a
race condition between the updating buffer in NMI and sink's interrupt
handler.  To avoid the race condition, this commit disallows updating
buffer on AUX pause for the per CPU sink.  Currently, this is only
applied for TRBE.

Signed-off-by: default avatarLeo Yan <leo.yan@arm.com>
Reviewed-by: default avatarJames Clark <james.clark@linaro.org>
Signed-off-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20250401180708.385396-7-leo.yan@arm.com
parent d5f7e4be

drivers/hwtracing/coresight/coresight-etm-perf.c

+41 −2
Original line number Diff line number Diff line
@@ -574,14 +574,53 @@ static void etm_event_start(struct perf_event *event, int flags) 
	return;

}



static void etm_event_pause(struct coresight_device *csdev,

static void etm_event_pause(struct perf_event *event,

			    struct coresight_device *csdev,

			    struct etm_ctxt *ctxt)

{

	int cpu = smp_processor_id();

	struct coresight_device *sink;

	struct perf_output_handle *handle = &ctxt->handle;

	struct coresight_path *path;

	unsigned long size;



	if (!ctxt->event_data)

		return;



	/* Stop tracer */

	coresight_pause_source(csdev);



	path = etm_event_cpu_path(ctxt->event_data, cpu);

	sink = coresight_get_sink(path);

	if (WARN_ON_ONCE(!sink))

		return;



	/*

	 * The per CPU sink has own interrupt handling, it might have

	 * race condition with updating buffer on AUX trace pause if

	 * it is invoked from NMI.  To avoid the race condition,

	 * disallows updating buffer for the per CPU sink case.

	 */

	if (coresight_is_percpu_sink(sink))

		return;



	if (WARN_ON_ONCE(handle->event != event))

		return;



	if (!sink_ops(sink)->update_buffer)

		return;



	size = sink_ops(sink)->update_buffer(sink, handle,

					     ctxt->event_data->snk_config);

	if (READ_ONCE(handle->event)) {

		if (!size)

			return;



		perf_aux_output_end(handle, size);

		perf_aux_output_begin(handle, event);

	} else {

		WARN_ON_ONCE(size);

	}

}



static void etm_event_stop(struct perf_event *event, int mode)
@@ -595,7 +634,7 @@ static void etm_event_stop(struct perf_event *event, int mode) 
	struct coresight_path *path;



	if (mode & PERF_EF_PAUSE)

		return etm_event_pause(csdev, ctxt);

		return etm_event_pause(event, csdev, ctxt);



	/*

	 * If we still have access to the event_data via handle,