Commit 9773547b authored by Kent Overstreet's avatar Kent Overstreet
Browse files

bcachefs: Convert disk accounting BUG_ON() to WARN_ON() 



We had a bug where disk accounting keys didn't always have their version
field set in journal replay; change the BUG_ON() to a WARN(), and
exclude this case since it's now checked for elsewhere (in the bkey
validate function).

Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent a3581ca3

fs/bcachefs/disk_accounting.c

+1 −1
Original line number Diff line number Diff line
@@ -648,7 +648,7 @@ int bch2_accounting_read(struct bch_fs *c) 
			if (i + 1 < &darray_top(*keys) &&

			    i[1].k->k.type == KEY_TYPE_accounting &&

			    !journal_key_cmp(i, i + 1)) {

				BUG_ON(bversion_cmp(i[0].k->k.bversion, i[1].k->k.bversion) >= 0);

				WARN_ON(bversion_cmp(i[0].k->k.bversion, i[1].k->k.bversion) >= 0);



				i[1].journal_seq = i[0].journal_seq;