Commit 978d13b2 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: stmmac: intel: remove unnecessary setting max_speed 



Phylink will already limit the MAC speed according to the interface,
so if 2500BASE-X is selected, the maximum speed will be 2.5G.
Similarly, if SGMII is selected, the maximum speed will be 1G.
It is, therefore, not necessary to set a speed limit. Remove setting
plat_dat->max_speed from this glue driver.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/E1u4dIh-000dT5-Kt@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent cd1fafe7

drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c

+0 −3
Original line number Diff line number Diff line
@@ -300,11 +300,8 @@ static void intel_speed_mode_2500(struct net_device *ndev, void *intel_data) 
	if (((data & SERDES_LINK_MODE_MASK) >> SERDES_LINK_MODE_SHIFT) ==

	    SERDES_LINK_MODE_2G5) {

		dev_info(priv->device, "Link Speed Mode: 2.5Gbps\n");

		priv->plat->max_speed = 2500;

		priv->plat->phy_interface = PHY_INTERFACE_MODE_2500BASEX;

		priv->plat->mdio_bus_data->default_an_inband = false;

	} else {

		priv->plat->max_speed = 1000;

	}

}