Commit 97aab852 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Guenter Roeck
Browse files

hwmon: gigabyte_waterforce: Fix locking bug in waterforce_get_status() 



Goto 'unlock_and_return' for unlocking before returning on the error
path.

Fixes: d5939a793693 ("hwmon: Add driver for Gigabyte AORUS Waterforce AIO coolers")
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: default avatarAleksa Savic <savicaleksa83@gmail.com>
Link: https://lore.kernel.org/r/20240122154952.2851934-1-harshit.m.mogalapalli@oracle.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 6613476e

drivers/hwmon/gigabyte_waterforce.c

+1 −1
Original line number Diff line number Diff line
@@ -146,7 +146,7 @@ static int waterforce_get_status(struct waterforce_data *priv) 
	/* Send command for getting status */

	ret = waterforce_write_expanded(priv, get_status_cmd, GET_STATUS_CMD_LENGTH);

	if (ret < 0)

		return ret;

		goto unlock_and_return;



	ret = wait_for_completion_interruptible_timeout(&priv->status_report_received,

							msecs_to_jiffies(STATUS_VALIDITY));