Commit 97ae4595 authored by Tim Crawford's avatar Tim Crawford Committed by Hans de Goede
Browse files

platform/x86: system76_acpi: Fix input device error handling 



Users on darp6 that do not have Open EC firmware have reported crashes
on boot. Correct the error handling for the input device to fix it.

Managed devices do not need to be explicitly unregistered or freed, as
this is handled by devres. Drop the call to input_free_device.

Fixes: 0de30fc6 ("platform/x86: system76_acpi: Replace Fn+F2 function for OLED models")
Signed-off-by: default avatarTim Crawford <tcrawford@system76.com>
Link: https://lore.kernel.org/r/20211030154213.2515-1-tcrawford@system76.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent bf653b61

drivers/platform/x86/system76_acpi.c

+0 −1
Original line number Diff line number Diff line
@@ -739,7 +739,6 @@ static int system76_add(struct acpi_device *acpi_dev) 
error:

	kfree(data->ntmp);

	kfree(data->nfan);

	input_free_device(data->input);

	return err;

}