Commit 97ceddbc authored by Jinyang He's avatar Jinyang He Committed by Huacai Chen
Browse files

LoongArch: Set unwind stack type to unknown rather than set error flag 



During unwinding, unwind_done() is used as an end condition. Normally it
unwind to the user stack and then set the stack type to unknown, which
is a normal exit. When something unexpected happens in unwind process
and we cannot unwind anymore, we should set the error flag, and also set
the stack type to unknown to indicate that the unwind process can not
continue. The error flag emphasizes that the unwind process produce an
unexpected error. There is no unexpected things when we unwind the PT_REGS
in the top of IRQ stack and find out that is an user mode PT_REGS. Thus,
we should not set error flag and just set stack type to unknown.

Reported-by: default avatarHengqi Chen <hengqi.chen@gmail.com>
Acked-by: default avatarHengqi Chen <hengqi.chen@gmail.com>
Signed-off-by: default avatarJinyang He <hejinyang@loongson.cn>
Signed-off-by: default avatarHuacai Chen <chenhuacai@loongson.cn>
parent 8146c5b3

arch/loongarch/kernel/stacktrace.c

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ void arch_stack_walk(stack_trace_consume_fn consume_entry, void *cookie, 
	}



	for (unwind_start(&state, task, regs);

	     !unwind_done(&state) && !unwind_error(&state); unwind_next_frame(&state)) {

	     !unwind_done(&state); unwind_next_frame(&state)) {

		addr = unwind_get_return_address(&state);

		if (!addr || !consume_entry(cookie, addr))

			break;

arch/loongarch/kernel/unwind.c

+0 −1
Original line number Diff line number Diff line
@@ -28,6 +28,5 @@ bool default_next_frame(struct unwind_state *state) 


	} while (!get_stack_info(state->sp, state->task, info));



	state->error = true;

	return false;

}

arch/loongarch/kernel/unwind_prologue.c

+1 −1
Original line number Diff line number Diff line
@@ -227,7 +227,7 @@ static bool next_frame(struct unwind_state *state) 
	} while (!get_stack_info(state->sp, state->task, info));



out:

	state->error = true;

	state->stack_info.type = STACK_TYPE_UNKNOWN;

	return false;

}