Commit 980e3016 authored by Yi Liu's avatar Yi Liu Committed by Joerg Roedel
Browse files

iommu: Make set_dev_pasid op support domain replacement 



The iommu core is going to support domain replacement for pasid, it needs
to make the set_dev_pasid op support replacing domain and keep the old
domain config in the failure case.

AMD iommu driver does not support domain replacement for pasid yet, so it
would fail the set_dev_pasid op to keep the old config if the input @old
is non-NULL. Till now, all the set_dev_pasid callbacks can handle the old
parameter and can keep the old config when failed, so update the kdoc of
set_dev_pasid op.

Suggested-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Reviewed-by: default avatarVasant Hegde <vasant.hegde@amd.com>
Signed-off-by: default avatarYi Liu <yi.l.liu@intel.com>
Link: https://lore.kernel.org/r/20241107122234.7424-14-yi.l.liu@intel.com


Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent e9f1f727

drivers/iommu/amd/pasid.c

+3 −0
Original line number Diff line number Diff line
@@ -109,6 +109,9 @@ int iommu_sva_set_dev_pasid(struct iommu_domain *domain, 
	unsigned long flags;

	int ret = -EINVAL;



	if (old)

		return -EOPNOTSUPP;



	/* PASID zero is used for requests from the I/O device without PASID */

	if (!is_pasid_valid(dev_data, pasid))

		return ret;

include/linux/iommu.h

+2 −1
Original line number Diff line number Diff line
@@ -616,7 +616,8 @@ struct iommu_ops { 
 * * EBUSY	- device is attached to a domain and cannot be changed

 * * ENODEV	- device specific errors, not able to be attached

 * * <others>	- treated as ENODEV by the caller. Use is discouraged

 * @set_dev_pasid: set an iommu domain to a pasid of device

 * @set_dev_pasid: set or replace an iommu domain to a pasid of device. The pasid of

 *                 the device should be left in the old config in error case.

 * @map_pages: map a physically contiguous set of pages of the same size to

 *             an iommu domain.

 * @unmap_pages: unmap a number of pages of the same size from an iommu domain