Commit 9966b782 authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

KVM: x86: do not allow re-enabling quirks 



Allowing arbitrary re-enabling of quirks puts a limit on what the
quirks themselves can do, since you cannot assume that the quirk
prevents a particular state.  More important, it also prevents
KVM from disabling a quirk at VM creation time, because userspace
can always go back and re-enable that.

Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 26eab9ae

arch/x86/kvm/x86.c

+1 −1
Original line number Diff line number Diff line
@@ -6533,7 +6533,7 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, 
			break;

		fallthrough;

	case KVM_CAP_DISABLE_QUIRKS:

		kvm->arch.disabled_quirks = cap->args[0];

		kvm->arch.disabled_quirks |= cap->args[0];

		r = 0;

		break;

	case KVM_CAP_SPLIT_IRQCHIP: {