Commit 99b74db1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Boris Brezillon
Browse files

drm/panthor: Fix error code in panthor_gpu_init()



This code accidentally returns zero/success on error because of a typo.
It should be "irq" instead of "ret".  The other thing is that if
platform_get_irq_byname() were to return zero then the error code would
be cmplicated.  Fortunately, it does not so we can just change <= to
< 0.

Fixes: 5cd894e2 ("drm/panthor: Add the GPU logical block")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarBoris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: default avatarBoris Brezillon <boris.brezillon@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/d753e684-43ee-45c2-a1fd-86222da204e1@moroto.mountain
parent d3373326
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -211,8 +211,8 @@ int panthor_gpu_init(struct panthor_device *ptdev)
		return ret;

	irq = platform_get_irq_byname(to_platform_device(ptdev->base.dev), "gpu");
	if (irq <= 0)
		return ret;
	if (irq < 0)
		return irq;

	ret = panthor_request_gpu_irq(ptdev, &ptdev->gpu->irq, irq, GPU_INTERRUPTS_MASK);
	if (ret)