Commit 99d36eed authored by Dipendra Khadka's avatar Dipendra Khadka Committed by Lee Jones
Browse files

leds: bcm6328: Replace divide condition with comparison for shift value 



Fixes the following Smatch warnings:
drivers/leds/leds-bcm6328.c:116 bcm6328_led_mode() warn: replace divide condition 'shift / 16' with 'shift >= 16'
drivers/leds/leds-bcm6328.c:360 bcm6328_led() warn: replace divide condition 'shift / 16' with 'shift >= 16'

Signed-off-by: default avatarDipendra Khadka <kdipendra88@gmail.com>
Reviewed-by: default avatarPavel Machek <pavel@ucw.cz>
Link: https://lore.kernel.org/r/20241019073302.35499-1-kdipendra88@gmail.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 09b1ef98

drivers/leds/leds-bcm6328.c

+2 −2
Original line number Diff line number Diff line
@@ -113,7 +113,7 @@ static void bcm6328_led_mode(struct bcm6328_led *led, unsigned long value) 
	unsigned long val, shift;



	shift = bcm6328_pin2shift(led->pin);

	if (shift / 16)

	if (shift >= 16)

		mode = led->mem + BCM6328_REG_MODE_HI;

	else

		mode = led->mem + BCM6328_REG_MODE_LO;
@@ -357,7 +357,7 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg, 
		break;

	case LEDS_DEFSTATE_KEEP:

		shift = bcm6328_pin2shift(led->pin);

		if (shift / 16)

		if (shift >= 16)

			mode = mem + BCM6328_REG_MODE_HI;

		else

			mode = mem + BCM6328_REG_MODE_LO;