Commit 9a039eeb authored by Moon Yeounsu's avatar Moon Yeounsu Committed by David S. Miller
Browse files

net: ethernet: use ip_hdrlen() instead of bit shift 



`ip_hdr(skb)->ihl << 2` is the same as `ip_hdrlen(skb)`
Therefore, we should use a well-defined function not a bit shift
to find the header length.

It also compresses two lines to a single line.

Signed-off-by: default avatarMoon Yeounsu <yyyynoom@gmail.com>
Reviewed-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent eb755a95

drivers/net/ethernet/jme.c

+4 −6
Original line number Diff line number Diff line
@@ -946,15 +946,13 @@ jme_udpsum(struct sk_buff *skb) 
	if (skb->protocol != htons(ETH_P_IP))

		return csum;

	skb_set_network_header(skb, ETH_HLEN);

	if ((ip_hdr(skb)->protocol != IPPROTO_UDP) ||

	    (skb->len < (ETH_HLEN +

			(ip_hdr(skb)->ihl << 2) +

			sizeof(struct udphdr)))) {



	if (ip_hdr(skb)->protocol != IPPROTO_UDP ||

	    skb->len < (ETH_HLEN + ip_hdrlen(skb) + sizeof(struct udphdr))) {

		skb_reset_network_header(skb);

		return csum;

	}

	skb_set_transport_header(skb,

			ETH_HLEN + (ip_hdr(skb)->ihl << 2));

	skb_set_transport_header(skb, ETH_HLEN + ip_hdrlen(skb));

	csum = udp_hdr(skb)->check;

	skb_reset_transport_header(skb);

	skb_reset_network_header(skb);