Commit 9a5beb6c authored by Maxim Levitsky's avatar Maxim Levitsky Committed by Jakub Kicinski
Browse files

net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs 



gc->irq_contexts is not freeded if one of the later operations
fail.

Suggested-by: default avatarMichael Kelley <mhklinux@outlook.com>
Fixes: 8afefc36 ("net: mana: Assigning IRQ affinity on HT cores")
Signed-off-by: default avatarMaxim Levitsky <mlevitsk@redhat.com>
Reviewed-by: default avatarMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: default avatarSaurabh Sengar <ssengar@linux.microsoft.com>
Reviewed-by: default avatarYury Norov <yury.norov@gmail.com>
Link: https://patch.msgid.link/20241209175751.287738-3-mlevitsk@redhat.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent bb1e3eb5

drivers/net/ethernet/microsoft/mana/gdma_main.c

+3 −2
Original line number Diff line number Diff line
@@ -1318,7 +1318,7 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev) 
				   GFP_KERNEL);

	if (!gc->irq_contexts) {

		err = -ENOMEM;

		goto free_irq_vector;

		goto free_irq_array;

	}



	for (i = 0; i < nvec; i++) {
@@ -1388,8 +1388,9 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev) 
	}



	kfree(gc->irq_contexts);

	kfree(irqs);

	gc->irq_contexts = NULL;

free_irq_array:

	kfree(irqs);

free_irq_vector:

	cpus_read_unlock();

	pci_free_irq_vectors(pdev);