Unverified Commit 9a8b202f authored by Shalini Manjunatha's avatar Shalini Manjunatha Committed by Mark Brown
Browse files

ASoC: soc-compress: Fix and add DPCM locking 



We find mising DPCM locking inside soc_compr_set_params_fe
before calling dpcm_be_dai_hw_params() and dpcm_be_dai_prepare()
which cause lockdep assert for DPCM lock not held in
__soc_pcm_hw_params() and __soc_pcm_prepare()

Signed-off-by: default avatarShalini Manjunatha <quic_c_shalma@quicinc.com>
Link: https://msgid.link/r/d985beeafdd32316eb45f20811eb7926da7a796e.1709720380.git.quic_c_shalma@quicinc.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f107ffca

sound/soc/soc-compress.c

+4 −0
Original line number Diff line number Diff line
@@ -385,11 +385,15 @@ static int soc_compr_set_params_fe(struct snd_compr_stream *cstream, 


	fe->dpcm[stream].runtime_update = SND_SOC_DPCM_UPDATE_FE;



	snd_soc_dpcm_mutex_lock(fe);

	ret = dpcm_be_dai_hw_params(fe, stream);

	snd_soc_dpcm_mutex_unlock(fe);

	if (ret < 0)

		goto out;



	snd_soc_dpcm_mutex_lock(fe);

	ret = dpcm_be_dai_prepare(fe, stream);

	snd_soc_dpcm_mutex_unlock(fe);

	if (ret < 0)

		goto out;