Commit 9addea5d authored by David Carlier's avatar David Carlier Committed by Jakub Kicinski
Browse files

net: use get_random_u{16,32,64}() where appropriate 



Use the typed random integer helpers instead of
get_random_bytes() when filling a single integer variable.
The helpers return the value directly, require no pointer
or size argument, and better express intent.

Skipped sites writing into __be16 (netdevsim) and __le64
(ceph) fields where a direct assignment would trigger
sparse endianness warnings.

Signed-off-by: default avatarDavid Carlier <devnexen@gmail.com>
Reviewed-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20260407150758.5889-1-devnexen@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 581d2860

drivers/net/netdevsim/psample.c

+2 −2
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ static void nsim_dev_psample_md_prepare(const struct nsim_dev_psample *psample, 
	if (psample->out_tc_occ_max) {

		u64 out_tc_occ;



		get_random_bytes(&out_tc_occ, sizeof(u64));

		out_tc_occ = get_random_u64();

		md->out_tc_occ = out_tc_occ & (psample->out_tc_occ_max - 1);

		md->out_tc_occ_valid = 1;

	}
@@ -102,7 +102,7 @@ static void nsim_dev_psample_md_prepare(const struct nsim_dev_psample *psample, 
	if (psample->latency_max) {

		u64 latency;



		get_random_bytes(&latency, sizeof(u64));

		latency = get_random_u64();

		md->latency = latency & (psample->latency_max - 1);

		md->latency_valid = 1;

	}

net/core/net_namespace.c

+1 −1
Original line number Diff line number Diff line
@@ -411,7 +411,7 @@ static __net_init int preinit_net(struct net *net, struct user_namespace *user_n 
	ref_tracker_dir_init(&net->refcnt_tracker, 128, "net_refcnt");

	ref_tracker_dir_init(&net->notrefcnt_tracker, 128, "net_notrefcnt");



	get_random_bytes(&net->hash_mix, sizeof(u32));

	net->hash_mix = get_random_u32();

	net->dev_base_seq = 1;

	net->user_ns = user_ns;

net/mac80211/mesh_plink.c

+1 −1
Original line number Diff line number Diff line
@@ -712,7 +712,7 @@ void mesh_plink_timer(struct timer_list *t) 
				"Mesh plink for %pM (retry, timeout): %d %d\n",

				sta->sta.addr, sta->mesh->plink_retries,

				sta->mesh->plink_timeout);

			get_random_bytes(&rand, sizeof(u32));

			rand = get_random_u32();

			sta->mesh->plink_timeout = sta->mesh->plink_timeout +

					     rand % sta->mesh->plink_timeout;

			++sta->mesh->plink_retries;

net/mptcp/subflow.c

+2 −2
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ static void subflow_req_create_thmac(struct mptcp_subflow_request_sock *subflow_ 
	struct mptcp_sock *msk = subflow_req->msk;

	u8 hmac[SHA256_DIGEST_SIZE];



	get_random_bytes(&subflow_req->local_nonce, sizeof(u32));

	subflow_req->local_nonce = get_random_u32();



	subflow_generate_hmac(READ_ONCE(msk->local_key),

			      READ_ONCE(msk->remote_key),
@@ -1639,7 +1639,7 @@ int __mptcp_subflow_connect(struct sock *sk, const struct mptcp_pm_local *local, 
	ssk = sf->sk;

	subflow = mptcp_subflow_ctx(ssk);

	do {

		get_random_bytes(&subflow->local_nonce, sizeof(u32));

		subflow->local_nonce = get_random_u32();

	} while (!subflow->local_nonce);



	/* if 'IPADDRANY', the ID will be set later, after the routing */

net/openvswitch/flow_table.c

+1 −1
Original line number Diff line number Diff line
@@ -167,7 +167,7 @@ static struct table_instance *table_instance_alloc(int new_size) 


	ti->n_buckets = new_size;

	ti->node_ver = 0;

	get_random_bytes(&ti->hash_seed, sizeof(u32));

	ti->hash_seed = get_random_u32();



	return ti;

}