Commit 9ae0f262 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

usb: r8a66597-hcd: make read-only const arrays static 



Don't populate the read-only const arrays fifoaddr, fifosel and fifoctr
on the stack at run time, instead make them static.

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20240912132345.589397-1-colin.i.king@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7fa6b25d

drivers/usb/host/r8a66597-hcd.c

+3 −3
Original line number Diff line number Diff line
@@ -297,9 +297,9 @@ static void put_child_connect_map(struct r8a66597 *r8a66597, int address) 
static void set_pipe_reg_addr(struct r8a66597_pipe *pipe, u8 dma_ch)

{

	u16 pipenum = pipe->info.pipenum;

	const unsigned long fifoaddr[] = {D0FIFO, D1FIFO, CFIFO};

	const unsigned long fifosel[] = {D0FIFOSEL, D1FIFOSEL, CFIFOSEL};

	const unsigned long fifoctr[] = {D0FIFOCTR, D1FIFOCTR, CFIFOCTR};

	static const unsigned long fifoaddr[] = {D0FIFO, D1FIFO, CFIFO};

	static const unsigned long fifosel[] = {D0FIFOSEL, D1FIFOSEL, CFIFOSEL};

	static const unsigned long fifoctr[] = {D0FIFOCTR, D1FIFOCTR, CFIFOCTR};



	if (dma_ch > R8A66597_PIPE_NO_DMA)	/* dma fifo not use? */

		dma_ch = R8A66597_PIPE_NO_DMA;