Commit 9b04d8f0 authored by T Pratham's avatar T Pratham Committed by Herbert Xu
Browse files

crypto: aead - Fix reqsize handling 

Commit afddce13 ("crypto: api - Add reqsize to crypto_alg")
introduced cra_reqsize field in crypto_alg struct to replace type
specific reqsize fields. It looks like this was introduced specifically
for ahash and acomp from the commit description as subsequent commits
add necessary changes in these alg frameworks.

However, this is being recommended for use in all crypto algs
instead of setting reqsize using crypto_*_set_reqsize(). Using
cra_reqsize in aead algorithms, hence, causes memory corruptions and
crashes as the underlying functions in the algorithm framework have not
been updated to set the reqsize properly from cra_reqsize. [1]

Add proper set_reqsize calls in the aead init function to properly
initialize reqsize for these algorithms in the framework.

[1]: https://gist.github.com/Pratham-T/24247446f1faf4b7843e4014d5089f6b



Fixes: afddce13 ("crypto: api - Add reqsize to crypto_alg")
Signed-off-by: default avatarT Pratham <t-pratham@ti.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 66b9a095

crypto/aead.c

+1 −0
Original line number Diff line number Diff line
@@ -120,6 +120,7 @@ static int crypto_aead_init_tfm(struct crypto_tfm *tfm) 
	struct aead_alg *alg = crypto_aead_alg(aead);



	crypto_aead_set_flags(aead, CRYPTO_TFM_NEED_KEY);

	crypto_aead_set_reqsize(aead, crypto_tfm_alg_reqsize(tfm));



	aead->authsize = alg->maxauthsize;