Commit 9b75346e authored by Luca Ceresoli's avatar Luca Ceresoli
Browse files

drm/bridge: get the bridge returned by drm_bridge_get_prev_bridge() 



drm_bridge_get_prev_bridge() returns a bridge pointer that the
caller could hold for a long time. Increment the refcount of the returned
bridge and document it must be put by the caller.

Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/r/20250709-drm-bridge-alloc-getput-drm_bridge_get_prev_bridge-v1-1-34ba6f395aaa@bootlin.com


Signed-off-by: default avatarLuca Ceresoli <luca.ceresoli@bootlin.com>
parent 46c36685

include/drm/drm_bridge.h

+8 −1
Original line number Diff line number Diff line
@@ -1321,6 +1321,13 @@ drm_bridge_get_next_bridge(struct drm_bridge *bridge) 
 * drm_bridge_get_prev_bridge() - Get the previous bridge in the chain

 * @bridge: bridge object

 *

 * The caller is responsible of having a reference to @bridge via

 * drm_bridge_get() or equivalent. This function leaves the refcount of

 * @bridge unmodified.

 *

 * The refcount of the returned bridge is incremented. Use drm_bridge_put()

 * when done with it.

 *

 * RETURNS:

 * the previous bridge in the chain, or NULL if @bridge is the first.

 */
@@ -1330,7 +1337,7 @@ drm_bridge_get_prev_bridge(struct drm_bridge *bridge) 
	if (list_is_first(&bridge->chain_node, &bridge->encoder->bridge_chain))

		return NULL;



	return list_prev_entry(bridge, chain_node);

	return drm_bridge_get(list_prev_entry(bridge, chain_node));

}



/**