Commit 9b7f1804 authored by Jesse Brandeburg's avatar Jesse Brandeburg Committed by Tony Nguyen
Browse files

iavf: field prep conversion 



Refactor iavf driver to use FIELD_PREP(), which reduces lines of code
and adds clarity of intent.

This code was generated by the following coccinelle/spatch script and
then manually repaired.

Clean up a couple spots in the code that had repetitive
y = cpu_to_*((blah << blah_blah) & blat)
y |= cpu_to_*((blahs << blahs_blahs) & blats)
to
x = FIELD_PREP(blat blah)
x |= FIELD_PREP(blats, blahs)
y = cpu_to_*(x);

@prep2@
constant shift,mask;
type T;
expression a;
@@
-(((T)(a) << shift) & mask)
+FIELD_PREP(mask, a)

@prep@
constant shift,mask;
type T;
expression a;
@@
-((T)((a) << shift) & mask)
+FIELD_PREP(mask, a)

Cc: Julia Lawall <Julia.Lawall@inria.fr>
Cc: Ahmed Zaki <ahmed.zaki@intel.com>
Reviewed-by: default avatarMarcin Szycik <marcin.szycik@linux.intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: default avatarRafal Romanowski <rafal.romanowski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 9e3ab72c

drivers/net/ethernet/intel/iavf/iavf_common.c

+13 −18
Original line number Diff line number Diff line
@@ -331,6 +331,7 @@ static enum iavf_status iavf_aq_get_set_rss_lut(struct iavf_hw *hw, 
	struct iavf_aq_desc desc;

	struct iavf_aqc_get_set_rss_lut *cmd_resp =

		   (struct iavf_aqc_get_set_rss_lut *)&desc.params.raw;

	u16 flags;



	if (set)

		iavf_fill_default_direct_cmd_desc(&desc,
@@ -343,22 +344,18 @@ static enum iavf_status iavf_aq_get_set_rss_lut(struct iavf_hw *hw, 
	desc.flags |= cpu_to_le16((u16)IAVF_AQ_FLAG_BUF);

	desc.flags |= cpu_to_le16((u16)IAVF_AQ_FLAG_RD);



	cmd_resp->vsi_id =

			cpu_to_le16((u16)((vsi_id <<

					  IAVF_AQC_SET_RSS_LUT_VSI_ID_SHIFT) &

					  IAVF_AQC_SET_RSS_LUT_VSI_ID_MASK));

	cmd_resp->vsi_id |= cpu_to_le16((u16)IAVF_AQC_SET_RSS_LUT_VSI_VALID);

	vsi_id = FIELD_PREP(IAVF_AQC_SET_RSS_LUT_VSI_ID_MASK, vsi_id) |

		 FIELD_PREP(IAVF_AQC_SET_RSS_LUT_VSI_VALID, 1);

	cmd_resp->vsi_id = cpu_to_le16(vsi_id);



	if (pf_lut)

		cmd_resp->flags |= cpu_to_le16((u16)

					((IAVF_AQC_SET_RSS_LUT_TABLE_TYPE_PF <<

					IAVF_AQC_SET_RSS_LUT_TABLE_TYPE_SHIFT) &

					IAVF_AQC_SET_RSS_LUT_TABLE_TYPE_MASK));

		flags = FIELD_PREP(IAVF_AQC_SET_RSS_LUT_TABLE_TYPE_MASK,

				   IAVF_AQC_SET_RSS_LUT_TABLE_TYPE_PF);

	else

		cmd_resp->flags |= cpu_to_le16((u16)

					((IAVF_AQC_SET_RSS_LUT_TABLE_TYPE_VSI <<

					IAVF_AQC_SET_RSS_LUT_TABLE_TYPE_SHIFT) &

					IAVF_AQC_SET_RSS_LUT_TABLE_TYPE_MASK));

		flags = FIELD_PREP(IAVF_AQC_SET_RSS_LUT_TABLE_TYPE_MASK,

				   IAVF_AQC_SET_RSS_LUT_TABLE_TYPE_VSI);



	cmd_resp->flags = cpu_to_le16(flags);



	status = iavf_asq_send_command(hw, &desc, lut, lut_size, NULL);
@@ -412,11 +409,9 @@ iavf_status iavf_aq_get_set_rss_key(struct iavf_hw *hw, u16 vsi_id, 
	desc.flags |= cpu_to_le16((u16)IAVF_AQ_FLAG_BUF);

	desc.flags |= cpu_to_le16((u16)IAVF_AQ_FLAG_RD);



	cmd_resp->vsi_id =

			cpu_to_le16((u16)((vsi_id <<

					  IAVF_AQC_SET_RSS_KEY_VSI_ID_SHIFT) &

					  IAVF_AQC_SET_RSS_KEY_VSI_ID_MASK));

	cmd_resp->vsi_id |= cpu_to_le16((u16)IAVF_AQC_SET_RSS_KEY_VSI_VALID);

	vsi_id = FIELD_PREP(IAVF_AQC_SET_RSS_KEY_VSI_ID_MASK, vsi_id) |

		 FIELD_PREP(IAVF_AQC_SET_RSS_KEY_VSI_VALID, 1);

	cmd_resp->vsi_id = cpu_to_le16(vsi_id);



	status = iavf_asq_send_command(hw, &desc, key, key_size, NULL);

drivers/net/ethernet/intel/iavf/iavf_fdir.c

+1 −1
Original line number Diff line number Diff line
@@ -358,7 +358,7 @@ iavf_fill_fdir_ip6_hdr(struct iavf_fdir_fltr *fltr, 


	if (fltr->ip_mask.tclass == U8_MAX) {

		iph->priority = (fltr->ip_data.tclass >> 4) & 0xF;

		iph->flow_lbl[0] = (fltr->ip_data.tclass << 4) & 0xF0;

		iph->flow_lbl[0] = FIELD_PREP(0xF0, fltr->ip_data.tclass);

		VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, IPV6, TC);

	}