Commit 9bf7123b authored by Brian Norris's avatar Brian Norris Committed by Sam Ravnborg
Browse files

drm/panel: Delete panel on mipi_dsi_attach() failure 



Many DSI panel drivers fail to clean up their panel references on
mipi_dsi_attach() failure, so we're leaving a dangling drm_panel
reference to freed memory. Clean that up on failure.

Noticed by inspection, after seeing similar problems on other drivers.
Therefore, I'm not marking Fixes/stable.

Signed-off-by: default avatarBrian Norris <briannorris@chromium.org>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210923173336.3.If9e74fa9b1d6eaa9e0e5b95b2b957b992740251c@changeid
parent 32a267e9

drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c

+7 −1
Original line number Diff line number Diff line
@@ -227,7 +227,13 @@ static int feiyang_dsi_probe(struct mipi_dsi_device *dsi) 
	dsi->format = MIPI_DSI_FMT_RGB888;

	dsi->lanes = 4;



	return mipi_dsi_attach(dsi);

	ret = mipi_dsi_attach(dsi);

	if (ret < 0) {

		drm_panel_remove(&ctx->panel);

		return ret;

	}



	return 0;

}



static int feiyang_dsi_remove(struct mipi_dsi_device *dsi)

drivers/gpu/drm/panel/panel-jdi-lt070me05000.c

+7 −1
Original line number Diff line number Diff line
@@ -473,7 +473,13 @@ static int jdi_panel_probe(struct mipi_dsi_device *dsi) 
	if (ret < 0)

		return ret;



	return mipi_dsi_attach(dsi);

	ret = mipi_dsi_attach(dsi);

	if (ret < 0) {

		jdi_panel_del(jdi);

		return ret;

	}



	return 0;

}



static int jdi_panel_remove(struct mipi_dsi_device *dsi)

drivers/gpu/drm/panel/panel-novatek-nt36672a.c

+7 −1
Original line number Diff line number Diff line
@@ -656,7 +656,13 @@ static int nt36672a_panel_probe(struct mipi_dsi_device *dsi) 
	if (err < 0)

		return err;



	return mipi_dsi_attach(dsi);

	err = mipi_dsi_attach(dsi);

	if (err < 0) {

		drm_panel_remove(&pinfo->base);

		return err;

	}



	return 0;

}



static int nt36672a_panel_remove(struct mipi_dsi_device *dsi)

drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c

+7 −1
Original line number Diff line number Diff line
@@ -241,7 +241,13 @@ static int wuxga_nt_panel_probe(struct mipi_dsi_device *dsi) 
	if (ret < 0)

		return ret;



	return mipi_dsi_attach(dsi);

	ret = mipi_dsi_attach(dsi);

	if (ret < 0) {

		wuxga_nt_panel_del(wuxga_nt);

		return ret;

	}



	return 0;

}



static int wuxga_nt_panel_remove(struct mipi_dsi_device *dsi)

drivers/gpu/drm/panel/panel-ronbo-rb070d30.c

+7 −1
Original line number Diff line number Diff line
@@ -199,7 +199,13 @@ static int rb070d30_panel_dsi_probe(struct mipi_dsi_device *dsi) 
	dsi->format = MIPI_DSI_FMT_RGB888;

	dsi->lanes = 4;



	return mipi_dsi_attach(dsi);

	ret = mipi_dsi_attach(dsi);

	if (ret < 0) {

		drm_panel_remove(&ctx->panel);

		return ret;

	}



	return 0;

}



static int rb070d30_panel_dsi_remove(struct mipi_dsi_device *dsi)