Commit 9c041384 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Christian Brauner
Browse files

xfs: respect the stable writes flag on the RT device 



Update the per-folio stable writes flag dependening on which device an
inode resides on.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20231025141020.192413-5-hch@lst.de


Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent c421df0b

fs/xfs/xfs_inode.h

+8 −0
Original line number Diff line number Diff line
@@ -569,6 +569,14 @@ extern void xfs_setup_inode(struct xfs_inode *ip); 
extern void xfs_setup_iops(struct xfs_inode *ip);

extern void xfs_diflags_to_iflags(struct xfs_inode *ip, bool init);



static inline void xfs_update_stable_writes(struct xfs_inode *ip)

{

	if (bdev_stable_writes(xfs_inode_buftarg(ip)->bt_bdev))

		mapping_set_stable_writes(VFS_I(ip)->i_mapping);

	else

		mapping_clear_stable_writes(VFS_I(ip)->i_mapping);

}



/*

 * When setting up a newly allocated inode, we need to call

 * xfs_finish_inode_setup() once the inode is fully instantiated at

fs/xfs/xfs_ioctl.c

+8 −0
Original line number Diff line number Diff line
@@ -1150,6 +1150,14 @@ xfs_ioctl_setattr_xflags( 
	ip->i_diflags2 = i_flags2;



	xfs_diflags_to_iflags(ip, false);



	/*

	 * Make the stable writes flag match that of the device the inode

	 * resides on when flipping the RT flag.

	 */

	if (rtflag != XFS_IS_REALTIME_INODE(ip) && S_ISREG(VFS_I(ip)->i_mode))

		xfs_update_stable_writes(ip);



	xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG);

	xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);

	XFS_STATS_INC(mp, xs_ig_attrchg);

fs/xfs/xfs_iops.c

+7 −0
Original line number Diff line number Diff line
@@ -1298,6 +1298,13 @@ xfs_setup_inode( 
	gfp_mask = mapping_gfp_mask(inode->i_mapping);

	mapping_set_gfp_mask(inode->i_mapping, (gfp_mask & ~(__GFP_FS)));



	/*

	 * For real-time inodes update the stable write flags to that of the RT

	 * device instead of the data device.

	 */

	if (S_ISREG(inode->i_mode) && XFS_IS_REALTIME_INODE(ip))

		xfs_update_stable_writes(ip);



	/*

	 * If there is no attribute fork no ACL can exist on this inode,

	 * and it can't have any file capabilities attached to it either.