Commit 9c981c86 authored by Dario Binacchi's avatar Dario Binacchi Committed by Stephen Boyd
Browse files

clk: stm32f4: fix an uninitialized variable 



The variable s, used by pr_debug() to print the mnemonic of the modulation
depth in use, was not initialized. Fix the output by addressing the correct
mnemonic.

Fixes: 65b3516d ("clk: stm32f4: support spread spectrum clock generation")
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/77355eb9-19b3-46e5-a003-c21c0fae5bcd@stanley.mountain


Signed-off-by: default avatarDario Binacchi <dario.binacchi@amarulasolutions.com>
Link: https://lore.kernel.org/r/20250124111711.1051436-1-dario.binacchi@amarulasolutions.com


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent a250cd4c

drivers/clk/clk-stm32f4.c

+2 −2
Original line number Diff line number Diff line
@@ -888,7 +888,6 @@ static int __init stm32f4_pll_ssc_parse_dt(struct device_node *np, 
					   struct stm32f4_pll_ssc *conf)

{

	int ret;

	const char *s;



	if (!conf)

		return -EINVAL;
@@ -916,7 +915,8 @@ static int __init stm32f4_pll_ssc_parse_dt(struct device_node *np, 
	conf->mod_type = ret;



	pr_debug("%pOF: SSCG settings: mod_freq: %d, mod_depth: %d mod_method: %s [%d]\n",

		 np, conf->mod_freq, conf->mod_depth, s, conf->mod_type);

		 np, conf->mod_freq, conf->mod_depth,

		 stm32f4_ssc_mod_methods[ret], conf->mod_type);



	return 0;

}