Commit 9d3fe6aa authored by Longlong Xia's avatar Longlong Xia Committed by Greg Kroah-Hartman
Browse files

devtmpfs: remove return value of devtmpfs_delete_node() 



The only caller of device_del() does not check the return value. And
there's nothing we can do when cleaning things up on a remove path.
Let's make it a void function.

Signed-off-by: default avatarLonglong Xia <xialonglong1@huawei.com>
Link: https://lore.kernel.org/r/20230210095444.4067307-4-xialonglong1@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 90a9d5ff

drivers/base/base.h

+2 −2
Original line number Diff line number Diff line
@@ -215,10 +215,10 @@ void device_pm_move_to_tail(struct device *dev); 


#ifdef CONFIG_DEVTMPFS

int devtmpfs_create_node(struct device *dev);

int devtmpfs_delete_node(struct device *dev);

void devtmpfs_delete_node(struct device *dev);

#else

static inline int devtmpfs_create_node(struct device *dev) { return 0; }

static inline int devtmpfs_delete_node(struct device *dev) { return 0; }

static inline void devtmpfs_delete_node(struct device *dev) { }

#endif



void software_node_notify(struct device *dev);

drivers/base/devtmpfs.c

+4 −4
Original line number Diff line number Diff line
@@ -147,22 +147,22 @@ int devtmpfs_create_node(struct device *dev) 
	return devtmpfs_submit_req(&req, tmp);

}



int devtmpfs_delete_node(struct device *dev)

void devtmpfs_delete_node(struct device *dev)

{

	const char *tmp = NULL;

	struct req req;



	if (!thread)

		return 0;

		return;



	req.name = device_get_devnode(dev, NULL, NULL, NULL, &tmp);

	if (!req.name)

		return -ENOMEM;

		return;



	req.mode = 0;

	req.dev = dev;



	return devtmpfs_submit_req(&req, tmp);

	devtmpfs_submit_req(&req, tmp);

}



static int dev_mkdir(const char *name, umode_t mode)