Commit 9d5043d9 authored by Ian Abbott's avatar Ian Abbott Committed by Greg Kroah-Hartman
Browse files

misc: hpilo: rename device creation loop variable 



In `ilo_probe()`, the loop variable `minor` isn't really the minor
device number, it's the channel or slot number.  Rename it to `slot` for
consistency.

Signed-off-by: default avatarIan Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20240119132032.106053-3-abbotti@mev.co.uk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1c9a697b

drivers/misc/hpilo.c

+4 −4
Original line number Diff line number Diff line
@@ -770,7 +770,7 @@ static void ilo_remove(struct pci_dev *pdev) 
static int ilo_probe(struct pci_dev *pdev,

			       const struct pci_device_id *ent)

{

	int devnum, minor, start, error = 0;

	int devnum, slot, start, error = 0;

	struct ilo_hwinfo *ilo_hw;



	if (pci_match_id(ilo_blacklist, pdev)) {
@@ -839,11 +839,11 @@ static int ilo_probe(struct pci_dev *pdev, 
		goto remove_isr;

	}



	for (minor = 0 ; minor < max_ccb; minor++) {

	for (slot = 0; slot < max_ccb; slot++) {

		struct device *dev;

		dev = device_create(&ilo_class, &pdev->dev,

				    MKDEV(ilo_major, start + minor), NULL,

				    "hpilo!d%dccb%d", devnum, minor);

				    MKDEV(ilo_major, start + slot), NULL,

				    "hpilo!d%dccb%d", devnum, slot);

		if (IS_ERR(dev))

			dev_err(&pdev->dev, "Could not create files\n");

	}