Commit 9da4e1dc authored by Tony Battersby's avatar Tony Battersby Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: target: Remove code for unsupported hardware 



As far as I can tell, CONTINUE_TGT_IO_TYPE and CTIO_A64_TYPE are message
types from non-FWI2 boards (older than ISP24xx), which are not supported
by qla_target.c.  Removing them makes it possible to turn a void * into
the real type and avoid some typecasts.

Signed-off-by: default avatarTony Battersby <tonyb@cybernetics.com>
Link: https://patch.msgid.link/cb006628-e321-4e30-a60b-08b37b8685a5@cybernetics.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 957aa597

drivers/scsi/qla2xxx/qla_target.c

+5 −27
Original line number Diff line number Diff line
@@ -3913,7 +3913,8 @@ static void *qlt_ctio_to_cmd(struct scsi_qla_host *vha, 
 * ha->hardware_lock supposed to be held on entry. Might drop it, then reaquire

 */

static void qlt_do_ctio_completion(struct scsi_qla_host *vha,

    struct rsp_que *rsp, uint32_t handle, uint32_t status, void *ctio)

	struct rsp_que *rsp, uint32_t handle, uint32_t status,

	struct ctio7_from_24xx *ctio)

{

	struct qla_hw_data *ha = vha->hw;

	struct se_cmd *se_cmd;
@@ -3934,11 +3935,8 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, 
	if (cmd == NULL)

		return;



	if ((le16_to_cpu(((struct ctio7_from_24xx *)ctio)->flags) & CTIO7_FLAGS_DATA_OUT) &&

	    cmd->sess) {

		qlt_chk_edif_rx_sa_delete_pending(vha, cmd->sess,

		    (struct ctio7_from_24xx *)ctio);

	}

	if ((le16_to_cpu(ctio->flags) & CTIO7_FLAGS_DATA_OUT) && cmd->sess)

		qlt_chk_edif_rx_sa_delete_pending(vha, cmd->sess, ctio);



	se_cmd = &cmd->se_cmd;

	cmd->cmd_sent_to_fw = 0;
@@ -4007,7 +4005,7 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, 
			    *((u64 *)&crc->actual_dif[0]),

			    *((u64 *)&crc->expected_dif[0]));



			qlt_handle_dif_error(qpair, cmd, ctio);

			qlt_handle_dif_error(qpair, cmd, crc);

			return;

		}
@@ -5816,26 +5814,6 @@ static void qlt_response_pkt(struct scsi_qla_host *vha, 
	}

	break;



	case CONTINUE_TGT_IO_TYPE:

	{

		struct ctio_to_2xxx *entry = (struct ctio_to_2xxx *)pkt;



		qlt_do_ctio_completion(vha, rsp, entry->handle,

		    le16_to_cpu(entry->status)|(pkt->entry_status << 16),

		    entry);

		break;

	}



	case CTIO_A64_TYPE:

	{

		struct ctio_to_2xxx *entry = (struct ctio_to_2xxx *)pkt;



		qlt_do_ctio_completion(vha, rsp, entry->handle,

		    le16_to_cpu(entry->status)|(pkt->entry_status << 16),

		    entry);

		break;

	}



	case IMMED_NOTIFY_TYPE:

		ql_dbg(ql_dbg_tgt, vha, 0xe035, "%s", "IMMED_NOTIFY\n");

		qlt_handle_imm_notify(vha, (struct imm_ntfy_from_isp *)pkt);