Commit 9dfbc26d authored by David Vernet's avatar David Vernet Committed by Ingo Molnar
Browse files

sched/fair: Remove unnecessary goto in update_sd_lb_stats() 



In update_sd_lb_stats(), when we're iterating over the sched groups that
comprise a sched domain, we're skipping the call to
update_sd_pick_busiest() for the sched group that contains the local /
destination CPU. We use a goto to skip the call, but we could just as
easily check !local_group, as there's no other logic that we need to
skip with the goto. Let's remove the goto, and check for !local_group in
the if statement instead.

Signed-off-by: default avatarDavid Vernet <void@manifault.com>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Reviewed-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: default avatarValentin Schneider <vschneid@redhat.com>
Link: https://lore.kernel.org/r/20240206043921.850302-2-void@manifault.com
parent 23d04d8c

kernel/sched/fair.c

+1 −6
Original line number Diff line number Diff line
@@ -10580,16 +10580,11 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd 


		update_sg_lb_stats(env, sds, sg, sgs, &sg_status);



		if (local_group)

			goto next_group;





		if (update_sd_pick_busiest(env, sds, sg, sgs)) {

		if (!local_group && update_sd_pick_busiest(env, sds, sg, sgs)) {

			sds->busiest = sg;

			sds->busiest_stat = *sgs;

		}



next_group:

		/* Now, start updating sd_lb_stats */

		sds->total_load += sgs->group_load;

		sds->total_capacity += sgs->group_capacity;