Commit 9e68817f authored by Wei Fang's avatar Wei Fang Committed by Jakub Kicinski
Browse files

net: enetc: avoid VF->PF mailbox timeout during SR-IOV teardown 



During SR-IOV teardown, enetc_msg_psi_free() disables the MR interrupt
before pci_disable_sriov() removes the VFs. If a VF sends a mailbox
message during this window, the PF cannot receive it, causing the VF to
timeout waiting for a reply.

Since the timeout occurs during SR-IOV teardown when the VF is about to
be removed anyway, it has no functional impact on operation. However,
more messages will be added in the future, some visible error logs may
confuse users. So fix it by calling pci_disable_sriov() first to remove
all VFs, then safely clean up the mailbox resources. This eliminates the
race window where VFs could send messages to an unresponsive PF.

Fixes: beb74ac8 ("enetc: Add vf to pf messaging support")
Signed-off-by: default avatarWei Fang <wei.fang@nxp.com>
Reviewed-by: default avatarHarshitha Ramamurthy <hramamurthy@google.com>
Link: https://patch.msgid.link/20260520064421.91569-10-wei.fang@nxp.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 54362b01

drivers/net/ethernet/freescale/enetc/enetc_pf.c

+1 −1
Original line number Diff line number Diff line
@@ -563,9 +563,9 @@ static int enetc_sriov_configure(struct pci_dev *pdev, int num_vfs) 
	int err;



	if (!num_vfs) {

		pci_disable_sriov(pdev);

		enetc_msg_psi_free(pf);

		pf->num_vfs = 0;

		pci_disable_sriov(pdev);

	} else {

		pf->num_vfs = num_vfs;