Commit 9ed145e6 authored by Dave Penkler's avatar Dave Penkler Committed by Greg Kroah-Hartman
Browse files

staging: gpib: Fix inadvertent negative shift 



During the initial checkpatch cleanup, when removing blanks
after open parentheses, a minus sign in the argument of a shift
operation was deleted by mistake. This transformed a pre-decrement
operation into a negation.

The result of a negative shift is undefined and a warning was
signalled by sparse.

Restore the pre-decrement operation.

Fixes: 6c52d5e3 ("staging: gpib: Add common include files for GPIB drivers")
Signed-off-by: default avatarDave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250116110014.15577-1-dpenkler@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d3fbbfa9

drivers/staging/gpib/include/amcc5920.h

+1 −1
Original line number Diff line number Diff line
@@ -22,7 +22,7 @@ static const int bits_per_region = 8; 


static inline uint32_t amcc_wait_state_bits(unsigned int region, unsigned int num_wait_states)

{

	return (num_wait_states & 0x7) << (-region * bits_per_region);

	return (num_wait_states & 0x7) << (--region * bits_per_region);

};



enum amcc_prefetch_bits {