Commit 9f544d26 authored by Paulo Alcantara's avatar Paulo Alcantara Committed by Steve French
Browse files

smb: client: get rid of bounds check in SMB2_ioctl_init() 



smb2_set_next_command() no longer squashes request iovs into a single
iov, so the bounds check can be dropped.

Cc: David Howells <dhowells@redhat.com>
Signed-off-by: default avatarPaulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent bc925c12

fs/smb/client/smb2pdu.c

+0 −9
Original line number Diff line number Diff line
@@ -3313,15 +3313,6 @@ SMB2_ioctl_init(struct cifs_tcon *tcon, struct TCP_Server_Info *server, 
		return rc;



	if (indatalen) {

		unsigned int len;



		if (WARN_ON_ONCE(smb3_encryption_required(tcon) &&

				 (check_add_overflow(total_len - 1,

						     ALIGN(indatalen, 8), &len) ||

				  len > MAX_CIFS_SMALL_BUFFER_SIZE))) {

			cifs_small_buf_release(req);

			return -EIO;

		}

		/*

		 * indatalen is usually small at a couple of bytes max, so

		 * just allocate through generic pool