Commit 9f734cd0 authored by Kent Overstreet's avatar Kent Overstreet
Browse files

bcachefs: Fix want_new_bset() so we write until the end of the btree node 



want_new_bset() returns the address of a new bset to initialize if we
wish to do so in a btree node - either because the previous one is too
big, or because it's been written.

The case for 'previous bset was written' was wrong: it's only supposed
to check for if we have space in the node for one more block, but
because it subtracted the header from the space available it would never
initialize a new bset if we were down to the last block in a node.

Fixing this results in fewer btree node splits/compactions, which fixes
a bug with flushing the journal to go read-only sometimes not
terminating or taking excessively long.

Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent 1e690efa

fs/bcachefs/btree_update_interior.h

+2 −2
Original line number Diff line number Diff line
@@ -278,12 +278,12 @@ static inline struct btree_node_entry *want_new_bset(struct bch_fs *c, struct bt 
{

	struct bset_tree *t = bset_tree_last(b);

	struct btree_node_entry *bne = max(write_block(b),

			(void *) btree_bkey_last(b, bset_tree_last(b)));

			(void *) btree_bkey_last(b, t));

	ssize_t remaining_space =

		__bch2_btree_u64s_remaining(b, bne->keys.start);



	if (unlikely(bset_written(b, bset(b, t)))) {

		if (remaining_space > (ssize_t) (block_bytes(c) >> 3))

		if (b->written + block_sectors(c) <= btree_sectors(c))

			return bne;

	} else {

		if (unlikely(bset_u64s(t) * sizeof(u64) > btree_write_set_buffer(b)) &&