Unverified Commit 9f944d2e authored by Björn Töpel's avatar Björn Töpel Committed by Palmer Dabbelt
Browse files

riscv: Require FRAME_POINTER for some configurations 



Some V configurations implicitly turn on '-fno-omit-frame-pointer',
but leaving FRAME_POINTER disabled. This makes it hard to reason about
the FRAME_POINTER config, and also triggers build failures introduced
in by the commit in the Fixes: tag.

Select FRAME_POINTER explicitly for these configurations.

Fixes: ebc9cb03 ("riscv: stack: Fixup independent softirq stack for CONFIG_FRAME_POINTER=n")
Signed-off-by: default avatarBjörn Töpel <bjorn@rivosinc.com>
Tested-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Acked-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Reviewed-by: default avatarConor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20230823082845.354839-1-bjorn@kernel.org


Signed-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
parent 174e8ac0

arch/riscv/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -62,6 +62,7 @@ config RISCV 
	select COMMON_CLK

	select CPU_PM if CPU_IDLE || HIBERNATION

	select EDAC_SUPPORT

	select FRAME_POINTER if PERF_EVENTS || (FUNCTION_TRACER && !DYNAMIC_FTRACE)

	select GENERIC_ARCH_TOPOLOGY

	select GENERIC_ATOMIC64 if !64BIT

	select GENERIC_CLOCKEVENTS_BROADCAST if SMP

arch/riscv/Makefile

+0 −3
Original line number Diff line number Diff line
@@ -87,9 +87,6 @@ endif 
ifeq ($(CONFIG_CMODEL_MEDANY),y)

	KBUILD_CFLAGS += -mcmodel=medany

endif

ifeq ($(CONFIG_PERF_EVENTS),y)

        KBUILD_CFLAGS += -fno-omit-frame-pointer

endif



# Avoid generating .eh_frame sections.

KBUILD_CFLAGS += -fno-asynchronous-unwind-tables -fno-unwind-tables