Commit 9fbb6260 authored by Viresh Kumar's avatar Viresh Kumar
Browse files

OPP: Remove dev_pm_opp_find_freq_ceil_by_volt() 



This was added few years back, but the code that was supposed to use it
never got merged. Remove the unused helper.

Tested-by: default avatarDmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 1f378c6e

drivers/opp/core.c

+0 −54
Original line number Diff line number Diff line
@@ -607,60 +607,6 @@ struct dev_pm_opp *dev_pm_opp_find_freq_floor(struct device *dev, 
}

EXPORT_SYMBOL_GPL(dev_pm_opp_find_freq_floor);



/**

 * dev_pm_opp_find_freq_ceil_by_volt() - Find OPP with highest frequency for

 *					 target voltage.

 * @dev:	Device for which we do this operation.

 * @u_volt:	Target voltage.

 *

 * Search for OPP with highest (ceil) frequency and has voltage <= u_volt.

 *

 * Return: matching *opp, else returns ERR_PTR in case of error which should be

 * handled using IS_ERR.

 *

 * Error return values can be:

 * EINVAL:	bad parameters

 *

 * The callers are required to call dev_pm_opp_put() for the returned OPP after

 * use.

 */

struct dev_pm_opp *dev_pm_opp_find_freq_ceil_by_volt(struct device *dev,

						     unsigned long u_volt)

{

	struct opp_table *opp_table;

	struct dev_pm_opp *temp_opp, *opp = ERR_PTR(-ERANGE);



	if (!dev || !u_volt) {

		dev_err(dev, "%s: Invalid argument volt=%lu\n", __func__,

			u_volt);

		return ERR_PTR(-EINVAL);

	}



	opp_table = _find_opp_table(dev);

	if (IS_ERR(opp_table))

		return ERR_CAST(opp_table);



	mutex_lock(&opp_table->lock);



	list_for_each_entry(temp_opp, &opp_table->opp_list, node) {

		if (temp_opp->available) {

			if (temp_opp->supplies[0].u_volt > u_volt)

				break;

			opp = temp_opp;

		}

	}



	/* Increment the reference count of OPP */

	if (!IS_ERR(opp))

		dev_pm_opp_get(opp);



	mutex_unlock(&opp_table->lock);

	dev_pm_opp_put_opp_table(opp_table);



	return opp;

}

EXPORT_SYMBOL_GPL(dev_pm_opp_find_freq_ceil_by_volt);



/**

 * dev_pm_opp_find_level_exact() - search for an exact level

 * @dev:		device for which we do this operation

include/linux/pm_opp.h

+0 −8
Original line number Diff line number Diff line
@@ -118,8 +118,6 @@ struct dev_pm_opp *dev_pm_opp_find_freq_exact(struct device *dev, 
					      bool available);

struct dev_pm_opp *dev_pm_opp_find_freq_floor(struct device *dev,

					      unsigned long *freq);

struct dev_pm_opp *dev_pm_opp_find_freq_ceil_by_volt(struct device *dev,

						     unsigned long u_volt);



struct dev_pm_opp *dev_pm_opp_find_level_exact(struct device *dev,

					       unsigned int level);
@@ -265,12 +263,6 @@ static inline struct dev_pm_opp *dev_pm_opp_find_freq_floor(struct device *dev, 
	return ERR_PTR(-EOPNOTSUPP);

}



static inline struct dev_pm_opp *dev_pm_opp_find_freq_ceil_by_volt(struct device *dev,

					unsigned long u_volt)

{

	return ERR_PTR(-EOPNOTSUPP);

}



static inline struct dev_pm_opp *dev_pm_opp_find_freq_ceil(struct device *dev,

					unsigned long *freq)

{